🌱 update controller runtime and cluster-api to newest version #1628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size/L
…1635) build(tools): make helm and hcloud downloads platform-agnostic Replace hardcoded `linux-amd64` architecture with dynamic `$(go env GOOS)-$(go env GOARCH)` to support multiple platforms and architectures during tool installation. Signed-off-by: Tomas Dabašinskas <[email protected]>
…1637) * 🌱 Add SkipCreatingHetznerSecretInWorkloadCluster to hetznercluster_controller SkipCreatingHetznerSecretInWorkloadCluster indicates whether the Hetzner secret should be created in the workload cluster. By default the secret gets created, so that the ccm (running in the wl-cluster) can use that secret. If you prefer to not reveal the secret in the workload cluster, you can set this to value to false, so that the secret is not created. Be sure to run the ccm outside of the workload cluster in that case, e.g. in the management cluster. Closes #1636
|
wrong golang version in ghcr.io/syself/caph-builder:1.0.24 |
|
I think I've found something: When I set the address (https://github.com/cgroschupp/cluster-api-provider-hetzner/blob/d2596bac2efadfcbdc92ac1f30cfa98e8fa5fdac/pkg/services/baremetal/baremetal/baremetal.go#L838) to a hardcoded value, for example '127.0.0.1', the test works. |
Merged
|
this is the fix 4735508 please pull from my branch. |
I am on that. |
…nto update-controller-runtime
thank you! I added some things, so errors in that part will fail earlier the next time. Please pull from my branch again. |
github-actions
bot
added
size/XL
|
hcloud e2e failed: 🌱 update controller runtime and cluster-api to newest version · syself/cluster-api-provider-hetzner@fe753d8 Will retry it.... Now I see
I will look at this tomorrow. |
|
The bm e2e failed. There seems to be a problem with host bm-e2e-1724024. Looks like it never reached the rescue system. I tried it by hand, and it worked. Strange. I will start the bm-e2e test again. |
Context: kubernetes-sigs/cluster-api#10784 We'll maintain them here for the time being, until we have conditions replacing these errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on PR of @cgroschupp 🌱 update controller runtime and cluster-api to newest version by cgroschupp · Pull Request #1623 · syself/cluster-api-provider-hetzner
TODO
"sigs.k8s.io/cluster-api/errors": Deprecate ancient errors/ package · Issue #10784 · kubernetes-sigs/cluster-api